Closed abacaphiliac closed 8 years ago
@Maks3w thanks for pointing out the lack of path coverage. i was able to reduce a bit of the complexity and i think my update now includes the line and path coverage you expect.
since it sounds like this must wait, would you like me to open a new pull request to develop instead of master?
do you know where i can find information on when SM v3 will be completed? i'm interested in reviewing the changes and contributing, if possible. do you anticipate that the new major version of this dependency will require a major version change for this package as well?
Target branch not affect to this PR to be on hold after the SM upgrade is done.
If you want you can forward that task proposing the SM adoption
Examples
https://github.com/zendframework/zend-serializer/pull/2 https://github.com/zendframework/zend-cache/pull/22 https://github.com/zendframework/zend-mvc/pull/36
excellent! thanks @weierophinney : )
pass configured input filter plugin manager to generated input filter factories to allow for complex input filter nesting. this enables reuse of named input filter services within nested input filter contexts.
i added more logic in the factory than i had originally intended, in order to preserve backwards compatibility.