[bc\break] Remove deprecated and validators auto injections

zendframework / zend-inputfilter

InputFilter component from Zend Framework

BSD 3-Clause "New" or "Revised" License

64 stars 50 forks source link

[bc\break] Remove deprecated and validators auto injections #83

Open Maks3w opened 8 years ago

Maks3w commented 8 years ago

Remove AllowEmpty / ContinueIfEmpty deprecated on 2.4.8. Zend\Validator\NotEmpty should be added to the ValidatorChain when expected.
Remove UploadFile validator auto injection Zend\Validator\File\UploadFile should be added to the ValidatorChain when expected.

ToDo:

[x] review coverage drop when uncovered lines grow

Maks3w commented 8 years ago

Code coverage drop its for a difference between phpunit code coverage versions.

weierophinney commented 8 years ago

@Maks3w can you drop into the summary how users can emulate the behavior using validators? Most will likely see this issue, see that the functionality was removed, but not know how to accomplish the behavior on their own.

Which brings me to the next point: can you start a migration/changes document detailing the change in behavior, please?

DASPRiD commented 8 years ago

@Maks3w Are you still working on this?

Maks3w commented 8 years ago

I'm not sure if continue with this or rewrite the component. There is not urgency for to merge this

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at https://github.com/laminas/laminas-inputfilter/issues/7.

weierophinney commented 4 years ago

This repository has been moved to laminas/laminas-inputfilter. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone laminas/laminas-inputfilter to another directory.
Copy the files from the second bullet point to the clone of laminas/laminas-inputfilter.
In your clone of laminas/laminas-inputfilter, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.