search

zendframework / zend-inputfilter

InputFilter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
64 stars 50 forks source link

[WIP] Migrate to ZF3 components #86

Closed gianarb closed 8 years ago

gianarb commented 8 years ago

ping @ezimuel Work in progress

Maks3w commented 8 years ago

Since this PR is similar to the rest of SMv3 PRs I think we should release a beta version of SMv3.

Following SMv3 betas should be backward compatible.

/cc @weierophinney

weierophinney commented 8 years ago

I plan to tag v2.7.0 and v3 of the SM early next week, add we've finished ironing out the migration issues. @ezimuel and I will then with up a plan to update the various components to target v2.7 (which will allow usage in both v2 and v3). On Jan 8, 2016 9:14 AM, "Maks3w" notifications@github.com wrote:

Since this PR is similar to the rest of SMv3 PRs I think we should release a beta version of SMv3.

Following SMv3 betas should be backward compatible.

/cc @weierophinney https://github.com/weierophinney

— Reply to this email directly or view it on GitHub https://github.com/zendframework/zend-inputfilter/pull/86#issuecomment-170028203 .

Maks3w commented 8 years ago

Sincerely I don't like nothing raise dependencies from 2.5 to 2.7 like has been do with stdlib.

  1. Teorically should work with 2.5
  2. If we have introcuced by accident any bug or backward incompatibility change then we will have a new nightmare like the changes was done between 2.3 and 2.4
kynx commented 8 years ago

I think your max nesting error is caused by https://github.com/zendframework/zend-inputfilter/blob/develop/src/Factory.php#L316 - calling get() is returning an existing instance. The following does the trick for me:

$inputFilter = $this->getInputFilterManager()->build($type);
kynx commented 8 years ago

Scratch that - protected $shareByDefault = false; -> protected $sharedByDefault = false; in InputFilterManager is the correct thing to do methinks.