search

zendframework / zend-inputfilter

InputFilter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
64 stars 50 forks source link

ServiceManager v2-v3 compatibility #95

Closed kynx closed 8 years ago

kynx commented 8 years ago

This builds on #86 adding ServiceManager v2/v3 compatibility.

The v2 tests will fail pending https://github.com/zendframework/zend-validator/pull/51

kynx commented 8 years ago

Nice one @Maks3w ! That makes flipping between versions when testing locally one heck of lot easier too :)

kynx commented 8 years ago

@Maks3w : doesn't look like the --prefer-lowest is going to work.

The fail is due to the minimum symfony/file version specified by php-cd-fixer, which is 2.1. The notPath() method it's failing on was introduced in 2.2, and even that is pretty ancient.

weierophinney commented 8 years ago

@kynx and @Maks3w — I tried it out with a couple of components this past week, and ran into similar issues; development tools were causing failures by composer to resolve dependencies. Specifying the upper and/or lower bounds as separate tests seems to work consistently and without issue.

Maks3w commented 8 years ago

@weierophinney Probably is an issue with the cached dependencies. Could you detail what issues did you had so I could investigate?

Recently I have refactored a Symfony Test suite from to test every Supported version (Currenlty 4) to only to test lowest and newest with the only issue of reset the cache.

Previous: https://travis-ci.org/Maks3w/FR3DLdapBundle/builds/108739742 Current: https://travis-ci.org/Maks3w/FR3DLdapBundle/builds/109023062