search

zendframework / zend-ldap

Ldap component from Zend Framework
BSD 3-Clause "New" or "Revised" License
29 stars 29 forks source link

Added an ldap_mod_del and ldap_mod_add functionality. #53

Closed martinjinda closed 7 years ago

martinjinda commented 8 years ago

This PR adds a way to delete or add one or more attributes to the specified dn.

This PR issue https://github.com/zendframework/zend-ldap/issues/5

heiglandreas commented 8 years ago

Thanks for your contribution!

I'll review it as soon as I'm back from holiday (being sunday).

martinjinda commented 8 years ago

Yep, hope it will be fine.

Enjoy vacation đź‘Ť

ThaDafinser commented 8 years ago

@martinjinda there is already a method deleteAttributes() https://github.com/zendframework/zend-ldap/blob/master/src/Ldap.php#L1314-L1339

Only the add method is missing or did i overseen something?

martinjinda commented 8 years ago

@ThaDafinser You didn't, but I did. So that's great. Plus I didn't control input from user in the entry at all.

heiglandreas commented 8 years ago

@martinjinda Thanks for your contribution. Can you please also add a test for the method?

heiglandreas commented 8 years ago

Damned Typo in a commit-message...

heiglandreas commented 7 years ago

@martinjinda Any news on this PR? I'D love to add it to the lib but I'd need some tests for that…

martinjinda commented 7 years ago

@heiglandreas Thanks for remind me. Will take a look.