Use connection string in non-ssl case when proto is not defined in host option

zendframework / zend-ldap

Ldap component from Zend Framework

BSD 3-Clause "New" or "Revised" License

29 stars 29 forks source link

Use connection string in non-ssl case when proto is not defined in host option #69

Closed fduch closed 6 years ago

fduch commented 7 years ago

For now inside connection procedure we surprisingly generating connection string in non-ssl mode and in when proto is not specified inside host option but never use it during factual connection which is probably wrong since we do not pass generated string (containing proto) to ldap_connect function.

This PR fixes this behaviour.

heiglandreas commented 7 years ago

Thanks for raising this issue! It brought up a much larger thing. Since the difference between URI-connect and the old one is only in there due to openldap-libraries older that version 2.2 and openldap 2.2 was tagged 11 years ago, we should probably remove this switch completely!

fduch commented 6 years ago

@heiglandreas, WDYT about finishing with it?)