Bad WriterInterface implementation

[naprstek]

AbstractWritter::setFormatter($formatter, array $options = null) does not conform WriterInterface::setFormatter($formatter).

Changed WriterInterface and all descendat subclasses.

Tests has the same result as master.

[michalbundyra]

@naprstek Duplicate of #79, but here I can see more changes

[Xerkus]

This is a BC break due to how php 7.2 handles addition of optional parameters to interfaces and overriden parents methods.

[samsonasik]

@naprstek can you register php 7.2 to .travis.yml file ?

[naprstek]

file updated (hope it is correct).

V.

---

S pozdravem Vladimír Náprstek

2018-04-09 19:14 GMT+02:00 Abdul Malik Ikhsan notifications@github.com:

@naprstek https://github.com/naprstek can you register php 7.2 to .travis.yml file ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-log/pull/86#issuecomment-379826283, or mute the thread https://github.com/notifications/unsubscribe-auth/ANnqDK9qZ18RTgFEIKeBX1g6K6uEO8Oeks5tm5brgaJpZM4TLbtR .

[samsonasik]

the zend-validator requirement at composer.json seems need to be upped to version at least ^2.10.1 which fixes the idn_to_utf8() error at php 7.2 environment. Once it updated, composer.lock need to be updated by run : composer update --prefer-lowest --prefer-stable and commit it. /cc @webimpress if any better suggestion

[samsonasik]

needs rebase

[weierophinney]

@naprstek I've rebased for you, and incorporated the changes I suggested.

[weierophinney]

THanks, @naprstek!