search

zendframework / zend-log

Log component from Zend Framework
BSD 3-Clause "New" or "Revised" License
62 stars 51 forks source link

Faulty PHP DocBlock in Psr.php #90

Closed KoenigsKind closed 6 years ago

KoenigsKind commented 6 years ago

Faulty PHP DocBlock:

https://github.com/zendframework/zend-log/blob/5cb1e94d203f3e2c2e848a66ec6888479906d0e8/src/Writer/Psr.php#L58-L59

A possible fix would be:

@param  array|Traversable|PsrLoggerInterface $options
@throws \Zend\Log\Exception\InvalidArgumentException

How to reproduce the issue

Open Psr.php in PhpStorm

dennybrandes commented 6 years ago

i added right use statement to file.

KoenigsKind commented 6 years ago

@dennybrandes

Nice, could you also change on line 59 the LoggerInterface to PsrLoggerInterface, as it's declared on line 15?

dennybrandes commented 6 years ago

@KoenigsKind It is changed.

Xerkus commented 6 years ago

Fixed by #93