Treat quote as value if already in quote using another delimiter - Githubissues

zendframework / zend-mail

Mail component from Zend Framework

BSD 3-Clause "New" or "Revised" License

96 stars 111 forks source link

Treat quote as value if already in quote using another delimiter #226

Open silvadiego opened 5 years ago

silvadiego commented 5 years ago

Fixes the issue as described in #222.

glensc commented 5 years ago

@silvadiego is this same problem? can you cherry-pick testcase from there?

https://github.com/zendframework/zend-mail/pull/224

glensc commented 5 years ago

not sure, should #224 be added to changelog too? but at least include #222 in changelog!

glensc commented 5 years ago

@weierophinney can we get this merged?

as noted in https://github.com/zendframework/zend-mail/pull/224, this is regression from changes from https://github.com/zendframework/zend-mail/pull/147 resolution i.e from your https://github.com/zendframework/zend-mail/commit/8aac5f7b4d354ea65128be6d2134d4648f47286d commit

glensc commented 5 years ago

@Xerkus ping?

glensc commented 5 years ago

@silvadiego I don't know what's this project merge policy (hardly anybody accepts changes here), but good practice is to squash useless commits to one commit and git push -f (three commits altering changelogs could be squashed)

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at https://github.com/laminas/laminas-mail/issues/18.

weierophinney commented 4 years ago

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone laminas/laminas-mail to another directory.
Copy the files from the second bullet point to the clone of laminas/laminas-mail.
In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.