search

zendframework / zend-modulemanager

ModuleManager component from Zend Framework
BSD 3-Clause "New" or "Revised" License
44 stars 27 forks source link

remove uneeded AutoloaderFactory::unregisterAutoloaders() #33

Closed remicollet closed 8 years ago

remicollet commented 8 years ago

This is no more needed.

In 2.6, as all registered autloaders were unregistered / registered again, this works.

In 2.7, only added autoloaders are unregistered, so this is not needed anymore

More, if default autoloader is Zend one (instead of composer one), this break, all the test suite.

 PHP Fatal error:  Class 'Zend\ModuleManager\Listener\ConfigListener' not found in
samsonasik commented 8 years ago

only in test really?

remicollet commented 8 years ago

only in test really?

1/ I don't see other calls

2/ test suite pass (or code coverage is not good enough ;)

samsonasik commented 8 years ago

based on the fatal error, the actual code needs to be removed?

remicollet commented 8 years ago

based on the fatal error, the actual code needs to be removed?

Yes, this is what this PR does.

samsonasik commented 8 years ago

I mean, the fuction unregisterAutoloaders() itself? I was seeing the same error when just fresh composer update and refresh browser

Warm regards,

Abdul Malik Ikhsan

Pada 29 Feb 2016, pukul 12.55, Remi Collet notifications@github.com menulis:

based on the fatal error, the actual code needs to be removed?

Yes, this is what this PR does.

— Reply to this email directly or view it on GitHub.

weierophinney commented 8 years ago

@samsonasik AutoloaderFactory::unregisterAutoloaders() still has a use case; it's just not needed in this test case any longer.

remicollet commented 8 years ago

Thanks for the merge