search

zendframework / zend-modulemanager

ModuleManager component from Zend Framework
BSD 3-Clause "New" or "Revised" License
44 stars 27 forks source link

minify var_export on AbstractListener::writeArrayToFile() #61

Closed samsonasik closed 7 years ago

samsonasik commented 7 years ago

from http://php.net/manual/fr/function.var-export.php#54440 tested in https://3v4l.org/gX3kA

Do we need tests file_put_contents with vfsStream?

weierophinney commented 7 years ago

What does this accomplish, exactly? What problem does it solve?

samsonasik commented 7 years ago

for performance, minified should be faster I think

weierophinney commented 7 years ago

for performance, minified should be faster I think

I'd like to see benchmarks, then. PHP code generally doesn't benefit from minimization efforts...

samsonasik commented 7 years ago

@weierophinney do you mean something a sample like in https://github.com/zendframework/zend-servicemanager/tree/master/benchmarks ?

Ocramius commented 7 years ago

Dito, plus var_export is a potential source of security issues if replaced with a custom solution.

On 11 Jul 2017 22:02, "weierophinney" notifications@github.com wrote:

for performance, minified should be faster I think

I'd like to see benchmarks, then. PHP code generally doesn't benefit from minimization efforts...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-modulemanager/pull/61#issuecomment-314555331, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakKj1uAAMXa5Z3ms5rYDa68k1p3Hgks5sM9TOgaJpZM4NdsWn .

weierophinney commented 7 years ago

Since @Ocramius brings up security implications, I'm going to close this.