Add phpstan tool - Githubissues

Xerkus commented 5 years ago

Added phpstan static analyser tool but did not provide fixes for errors it detected. Next major will necessary have wide reaching changes that will discard big chunk of possible fixes that can be done now. For this reason it is not included in travis builds at this time.

[ ] Are you fixing a bug?
[ ] Are you creating a new feature?
[x] Is this related to quality assurance? This PR adds static analysis tool to drive code quality in future development
[ ] Is this related to documentation?

Based on top of #302

Ocramius commented 5 years ago

@Xerkus this diff is massive: are there commits that we can exclude from it? Version bump maybe?

Xerkus commented 5 years ago

@Xerkus this diff is massive: are there commits that we can exclude from it? Version bump maybe?

@Ocramius apparently github does not update commit list/diff after another PR was merged. I wanted to avoid conflicts by making those PRs sequential Coding style PR is not merged yet tho.

Ocramius commented 5 years ago

@Xerkus CS patch is merged too :+1:

zendframework / zend-mvc

Add phpstan tool #303