zendframework / zend-navigation

Navigation component from Zend Framework
BSD 3-Clause "New" or "Revised" License
20 stars 25 forks source link

Forwards compatibility with zend-servicemanager v3 #20

Closed weierophinney closed 8 years ago

weierophinney commented 8 years ago

This patch reverts some of the changes from #5 in favor of making the component forwards compatible with v3. Specifically:

Additionally, this patch updates the Zend\Navigation\View\HelperConfig class to ensure it works correctly against both v2 and v3 releases of zend-servicemanager. In particular, it adds testing to the class, which uncovered an interesting situation: the documented navigation_helpers configuration previously did not work! With this patch, it now works correctly, regardless of version.

weierophinney commented 8 years ago

Marked as WIP, as realized the aliases and factory names listed in Zend\Navigation\View\HelperConfig need to be updated, based on feedback since the zend-view 2.6 release series..

weierophinney commented 8 years ago

No longer a WIP; all tested and working now!