zendframework / zend-navigation

Navigation component from Zend Framework
BSD 3-Clause "New" or "Revised" License
20 stars 25 forks source link

Code refactor with the new service manager #5

Closed ezimuel closed 8 years ago

ezimuel commented 8 years ago

This PR contains the refactor of the code using the new component of ZF3:

ezimuel commented 8 years ago

@weierophinney I started the refactoring of the code but I've the following errors in the unit tests:

1) ZendTest\Navigation\ServiceFactoryTest::testNavigationAbstractServiceFactory
Zend\ServiceManager\Exception\ServiceNotFoundException: Unable to resolve service "Application" to a factory; are you certain you provided it during configuration?
/.../zend-navigation/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:482
/.../zend-navigation/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:558
/.../zend-navigation/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:181
/.../zend-navigation/test/ServiceFactoryTest.php:83

2) ZendTest\Navigation\View\HelperConfigTest::testConfigureServiceManagerWithConfig
Zend\ServiceManager\Exception\ServiceNotFoundException: Unable to resolve service "Navigation" to a factory; are you certain you provided it during configuration?

/.../zend-navigation/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:482
/.../zend-navigation/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:558
/.../zend-navigation/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:181
/.../zend-navigation/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php:65
/.../zend-navigation/test/View/HelperConfigTest.php:54

Can you have a look? Thanks!