search

zendframework / zend-navigation

Navigation component from Zend Framework
BSD 3-Clause "New" or "Revised" License
20 stars 25 forks source link

Compatibility of legacy SM2 style in PHP 7.2. #70

Closed alextech closed 6 years ago

alextech commented 6 years ago

Fix #69. No need to dynamically request service name, when its known that Navigation::class is one ultimately being requested in __invoke

Test will not run against 7.2 because #59 is against dev, while that branch is probably tested against SM3 making this less relevant. Although, test for general creation ability can be ported to improve coverage.

weierophinney commented 6 years ago

I've rebased this from current develop, which contains updates for PHP 7.2 compatibility; I'll merge if/when the tests are green.

weierophinney commented 6 years ago

Thanks, @alextech!