search

zendframework / zend-paginator

Paginate collections of data from arbitrary sources.
BSD 3-Clause "New" or "Revised" License
36 stars 30 forks source link

Update DbTableGateway typehints #27

Closed weierophinney closed 6 years ago

weierophinney commented 8 years ago

Per this thread on zf-apigility, the DbTableGateway constructor currently requires a concrete Zend\Db\TableGateway\TableGateway instance, but should likely accept TableGatewayInterface instead. This would be a type loosening, which does not pose a BC break, but which would simplify mocking, and allow for alternate implementations when desired.

samsonasik commented 7 years ago

@weierophinney I've created PR https://github.com/zendframework/zend-paginator/pull/32 for it

froschdesign commented 7 years ago

For version 2 of zend-paginator and zend-db we will accept #32. But for a future version the typehint must be an interface.