search

zendframework / zend-paginator

Paginate collections of data from arbitrary sources.
BSD 3-Clause "New" or "Revised" License
36 stars 30 forks source link

Fixes paginator cache, problem with the generation of cacheInternalId #33

Closed rwrz closed 6 years ago

rwrz commented 7 years ago

This fix also fixes a future problem with complex Adapters that cannot be serializable. fixes #1 , joined the #24 and part of #30 , and included tests for both. Also, improved the method to get cacheInternalId to accept inherited adapter as well, without considering those the same adapters.

rwrz commented 7 years ago

@weierophinney I have fixed this cache problem, but Travis isn't working because there is a problem with a Trait in ServiceManager... and a problem with HHVM on unserialize function, but those problems aren't related to this fix. I tried to figure it out the HHVM problem, but couldn't.

FabianKoestring commented 7 years ago

Having the same problem! @rwrz still working on this?

weierophinney commented 6 years ago

@rwrz The build failures are due to an issue with the upstream zend-servicemanager library when using the latest version (essentially, a trait used in testing within this library is provided by that component, but it uses a newer PHPUnit version). I'll try and address that, and then merge this patch.

weierophinney commented 6 years ago

Thanks, @rwrz!