search

zendframework / zend-serializer

Serializer component from Zend Framework
BSD 3-Clause "New" or "Revised" License
45 stars 19 forks source link

Feature/add covers to tests #7

Closed levelfivehub closed 9 years ago

levelfivehub commented 9 years ago

@Maks3w

Following discussion, is this what we are after? Do not merge, until rest are complete for this component. This is just a sample - please add tag WIP.

What are your thoughts on group tag?

Maks3w commented 9 years ago

Only class level @covers. Method coverage may added in the future but not now.

Maks3w commented 9 years ago

I prefer do only one thing by commit. Remove things is risky and require more time for review

levelfivehub commented 9 years ago

Re-review, is this what you mean?

Maks3w commented 9 years ago

it's reasonable. Anyway focus on add @covers. Rest of changes made can by done later in different PRs

Maks3w commented 9 years ago

https://github.com/zendframework/zend-inputfilter/commit/60434bc2ed16efacbdef57f269cf5b1d8817bfc2

levelfivehub commented 9 years ago

I see what you mean. Watch out for next commit.

levelfivehub commented 9 years ago

I need to rebase and revert the other removal of group annotations. Too many commits. I will update you.

levelfivehub commented 9 years ago

Rebased.