search

zendframework / zend-servicemanager

ServiceManager component from Zend Framework
BSD 3-Clause "New" or "Revised" License
188 stars 89 forks source link

Conflict in doc and implementation #144

Open robob4him opened 8 years ago

robob4him commented 8 years ago

The documentation states that a factory stored in a class would implement FactoryInterface but it doesn't reference which one. In ZF3 there still exists the ZF2 FactoryInterface which requires a 'createService' method while the ZF3 interface requires '__invoke'.

It is confusing to still have the ZF2 implementation out there when the clear direction in the docs in ZF3. Perhaps it should be removed?

weierophinney commented 8 years ago

@robob4him Can you link to a specific page and heading where you see this occurring, please?

robob4him commented 8 years ago

@weierophinney, np.

https://zendframework.github.io/zend-servicemanager/configuring-the-service-manager/ It's the example after the text:

Alternatively, the above code can be replaced by a factory class instead of a closure. This leads to more readable code. For instance:

boesing commented 7 years ago

Uhm, thats all right by the way. There is no specific namespace given and since the new FactoryInterface is located under Zend\ServiceManager\Factory\FactoryInterface, there is no requirement for implementing the old Zend\ServiceManager\FactoryInterface which defined the createService method.

But yes, the lack of the use statement in the top of the snippet might lead to the wrong Interface tho.

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-servicemanager; a new issue has been opened at https://github.com/laminas/laminas-servicemanager/issues/23.