This PR fixes some severe bugs. Service manager does not process preconfiguration provided by child classes. Please see #242 for details.
I'd highly appreciate to get some qualified feedback on this. Same for #254.
All it would take to invalidate all the work done and time spent here was to merge something else upfront, as happened before by merging replace-this-with-self-for-no-particular-reason-and-no-measurable-benefit before this one. I would not consider such proceeding as being serious and responsible.
Ocramius
commented
6 years ago
This PR fixes some severe bugs. Service manager does not process preconfiguration provided by child classes. Please see #242 for details.
I'd highly appreciate to get some qualified feedback on this. Same for #254.
All it would take to invalidate all the work done and time spent here was to merge something else upfront, as happened before by merging replace-this-with-self-for-no-particular-reason-and-no-measurable-benefit before this one. I would not consider such proceeding as being serious and responsible.