remove redundant isset(s)

zendframework / zend-servicemanager

ServiceManager component from Zend Framework

BSD 3-Clause "New" or "Revised" License

188 stars 89 forks source link

remove redundant isset(s) #262

Open pine3ree opened 6 years ago

pine3ree commented 6 years ago

when we are also testing with ! empty() I believe we can skip isset() checks, as the execution speed is nearly the same (but it will double for positive isset)

Ocramius commented 6 years ago

@pine3ree as this is an improvement, please target develop

Ocramius commented 6 years ago

@pine3ree please attempt a rebase - don't merge upstream into your dev branches :)

pine3ree commented 6 years ago

Hello @Ocramius, I had changed the target branch of the pr from master to develop and resolved a resulting conflict. The files changes tab is now showing the correct changes I previously made for master. Did I do something wrong? kind regards.

Ocramius commented 6 years ago

@pine3ree ah, that's alright. If you are not familiar with the rebase process, I'll just do it on merge :-)

pine3ree commented 6 years ago

ok, thank You @Ocramius ! kind regards!

samsonasik commented 6 years ago

@pine3ree just in case you've other conflicted branch in other/next Pull Request, I made blog post about rebase conflicted branch https://samsonasik.wordpress.com/2015/09/16/practical-git-4-rebasing-conflicted-task-branch-against-primary-branch/

pine3ree commented 6 years ago

@samsonasik Thank You! that's very kind of You, sir! Regards!

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-servicemanager; a new issue has been opened at https://github.com/laminas/laminas-servicemanager/issues/12.

weierophinney commented 4 years ago

This repository has been moved to laminas/laminas-servicemanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone laminas/laminas-servicemanager to another directory.
Copy the files from the second bullet point to the clone of laminas/laminas-servicemanager.
In your clone of laminas/laminas-servicemanager, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.