search

zendframework / zend-servicemanager

ServiceManager component from Zend Framework
BSD 3-Clause "New" or "Revised" License
188 stars 89 forks source link

fixed coveralls config #98

Closed svycka closed 8 years ago

svycka commented 8 years ago

fixed coveralls config and restricted satooshi/php-coveralls to ^1.0 stable version

samsonasik commented 8 years ago

:+1: yes, the src_dir config is not needed in latest php-coveralls ^1.0, another components needs to be updated as well

samsonasik commented 8 years ago

@svycka would you mind to provide PR to other components as well ?

svycka commented 8 years ago

@samsonasik maybe, but just after this is merged because I don't know if there is everything ok.

samsonasik commented 8 years ago

I used same approach for my personal repos, and that's how it works, see travis log

Warm regards,

Abdul Malik Ikhsan

Pada 31 Mar 2016, pukul 12.18, Vytautas Stankus notifications@github.com menulis:

@samsonasik maybe, but just after this is merged because I don't know if there is everything ok.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

svycka commented 8 years ago

@samsonasik I know it works but not sure zf team will approve it. Maybe they want to specify source folder or does not want -v option or something I don't know so I am waiting until this is merged.

Ocramius commented 8 years ago

@svycka thanks, included into 3.1.0 via zendframework/zend-servicemanager@8129d6ebe7cef495a24e40b52c79cdede66b3a84