Replace continue with a break

zendframework / zend-stdlib

Stdlib component from Zend Framework

BSD 3-Clause "New" or "Revised" License

384 stars 76 forks source link

Closed trickii closed 5 years ago

trickii commented 5 years ago

Replace continue in switch to resolve a PHP 7.3 Warning.

Warning: "continue" targeting switch is equivalent to "break".

froschdesign commented 5 years ago

The problem is already fixed with version 3.2.1. You should do an update.

The target branch of your pull request is "release-2.7, but unfortunately that is wrong:

For fixes please use the "master" branch.
(see also: "What branch to issue the pull request against?")
Version 2 of zend-stdlib is no longer supported and can not be updated.
(More informations to the current supported versions can be found on the website: https://framework.zend.com/long-term-support)

trickii commented 5 years ago

We using ZF 2.5.3. It not accept std-lib 3.x

froschdesign commented 5 years ago

Version 2.5.3 is also an outdated version. So you have two options:

trickii commented 5 years ago

Jap, i know. I will use my fork for project. Update to 3 is in plan. But not now. Thanks.