search

zendframework / zend-stdlib

Stdlib component from Zend Framework
BSD 3-Clause "New" or "Revised" License
384 stars 76 forks source link

Missing multibyte extension in composer.json #53

Closed danrot closed 8 years ago

danrot commented 8 years ago

As you are using the multibyte extension in the string wrapper, this should also be mentioned in the composer.json file, like described in this blog post. I am running a project on heroku using this library, and I have to add this extension now to my project, although it would belong here.

Is there any reason not to add this? Otherwise I would provide a PR.

weierophinney commented 8 years ago

It can be added under the suggest section, but should not be under the require section. The reason is because all functionality in zend-stdlib is opt-in, and many components are using only ArrayUtils or the various SPL extensions.

danrot commented 8 years ago

Ok, we are using the zend search library, so should it be there in the require section?

weierophinney commented 8 years ago

@danrot Add it to the require section of your application; since your application requires it, that's the place to put it.

Ocramius commented 8 years ago

@danfinnie should be added to https://github.com/zendframework/ZendSearch, although that library is not maintained

danrot commented 8 years ago

@Ocramius Ok, any chance to add it there although it is not maintained? And I am just curious, but do you know any maintained alternative?

Ocramius commented 8 years ago

Not aware of any

danrot commented 8 years ago

Ok, then I gonna close this issue... Maybe I'll try to add that later to zend search, if that is ok, and there is any chance of anybody merging it.