search

zendframework / zend-stdlib

Stdlib component from Zend Framework
BSD 3-Clause "New" or "Revised" License
384 stars 76 forks source link

Switching to phpbench/phpbench based benchmarks #79

Closed michalbundyra closed 6 years ago

michalbundyra commented 7 years ago

/cc @Ocramius

froschdesign commented 6 years ago

@webimpress Can you check Travis please:

https://travis-ci.org/zendframework/zend-stdlib/jobs/285547904#L558

michalbundyra commented 6 years ago

@froschdesign We need #74 merged before. Travis CI configuration is not the best at this moment, and it force install (--ignore-platform-reqs) dependencies which are not compatible with PHP 7.0 (for example doctrine/annotations 1.5.0 requires PHP 7.1)...

froschdesign commented 6 years ago

@webimpress Right, in the meantime I have also seen this. I will update the Travis file and remove allow_failures, because the problem is already fixed (3921c941891a05189686886dbc4dadfbba089156)

michalbundyra commented 6 years ago

@froschdesign something definitely is wrong with this build, please note that I've moved cs-check, coverage and benchmarks to PHP 7.1 but build https://travis-ci.org/zendframework/zend-stdlib/builds/292168388?utm_source=github_status&utm_medium=notification still runs them on PHP 7! :-(

michalbundyra commented 6 years ago

@froschdesign rebased one more time, maybe now will be 💚

froschdesign commented 6 years ago

@webimpress Benchmark is running: https://travis-ci.org/zendframework/zend-stdlib/jobs/292185106#L640

michalbundyra commented 6 years ago

Ok, so benchmarks are ok, the problem is with cs-checks, because the variable was wrong and we haven't run it at all. I'd suggest to merge #68 and fix these cs issues there. What do you think @froschdesign ?

michalbundyra commented 6 years ago

@froschdesign Rebased, I hope last time !

michalbundyra commented 6 years ago

💚

froschdesign commented 6 years ago

@webimpress Thanks! 👍 👍 👍