zendframework / zend-stratigility

Middleware for PHP built on top of PSR-7 and PSR-15
BSD 3-Clause "New" or "Revised" License
235 stars 57 forks source link

ErrorHandler marked as final #176

Closed alwynn closed 5 years ago

alwynn commented 6 years ago

ErrorHandler middleware was marked as final but introduces a new public method (attachListener) that was not declared in MiddlewareInterface. This makes ErrorHandler not mockable and hard to use in tests.

This is similar to #144 and requires removing final keyword or creating an interface for ErrorHandler.

Xerkus commented 5 years ago

Fixed in 3.1.0