zendframework / zend-test

Test component from Zend Framework
BSD 3-Clause "New" or "Revised" License
18 stars 38 forks source link

Allow full, unfettered usage across all PHPUnit versions #48

Closed weierophinney closed 7 years ago

weierophinney commented 7 years ago

In reviewing #40 after-the-fact, I found a number of issues:

This patch does the following to fix these issues:

TODO

weierophinney commented 7 years ago

I've done the following with a skeleton application (which includes several controller unit tests):

I did the above using the current develop branch as well, to confirm that it was not working. Under PHPUnit 6, tests errored due to missing PHPUnit_Framework_TestCase (and likely others; as this is a required class for things to work at all, other tests may have failed as well); PHPUnit 5.7 passed (as the non-namespaced class exists already there; the namespaced version is aliased in that particular case), as did PHPUnit 4.8.

As such, I think this is ready!