search

zendframework / zend-test

Test component from Zend Framework
BSD 3-Clause "New" or "Revised" License
18 stars 38 forks source link

Update AbstractControllerTestCase.php #56

Closed SilverioMiranda closed 6 years ago

froschdesign commented 7 years ago

@SilverioMiranda Please add some description of the problem.

michalbundyra commented 6 years ago

I think this change is unneeded. Please consider test:

    public function testQueryStringInGetRequest()
    {
        $this->dispatch('/', 'GET', ['foo' => 'bar']);
        $this->assertEquals('foo=bar', $this->getRequest()->getQuery()->toString());
    }

and it's passing no matter if we have this change or not.

We are merging params passed in url and in params here: https://github.com/zendframework/zend-test/blob/master/src/PHPUnit/Controller/AbstractControllerTestCase.php#L258 and update query string in request later in: https://github.com/zendframework/zend-test/blob/master/src/PHPUnit/Controller/AbstractControllerTestCase.php#L274

SilverioMiranda commented 6 years ago

Sorry for not closing this PR earlier. At that time my problem is that some unknow module was clearing all query params and last month when update composer the problem fade away