search

zendframework / zend-test

Test component from Zend Framework
BSD 3-Clause "New" or "Revised" License
18 stars 38 forks source link

Fix for memory leak #69 #70

Closed ezimuel closed 5 years ago

ezimuel commented 5 years ago

This PR fixes the memory leak reported in https://github.com/zendframework/zend-test/issues/69

ezimuel commented 5 years ago

I'm working on the test part because the first approach, using fixed max memory usage, seems not working properly. I need to figure out a way to test the differential growth between tests.

froschdesign commented 5 years ago

@webimpress Please stop playing the style police before the real problem isn't resolved. Thanks! 😃

michalbundyra commented 5 years ago

@froschdesign As you see my comments were added before @ezimuel said it's not working properly. As he pushed and opened PR I thought it's done and ready for review. Sorry.

ezimuel commented 5 years ago

@froschdesign I'm sorry was my mistake, I put the WIP label after the @webimpress comments. Thanks @webimpress for your review, you beat me on time :)

froschdesign commented 5 years ago

@webimpress Travis was not finished! It would be good, if you can wait until the problem of the issue is resolved.

michalbundyra commented 5 years ago

@froschdesign As I said, PR was not marked as WIP, PR was pushed and opened. See above comment of @ezimuel and stop harassing me, please.

Ocramius commented 5 years ago

Folks, let's control the tone a bit - fairly sure that everyone is just doing their best to achieve the goal of better stability, let's not assume malice from either side, please :P

ezimuel commented 5 years ago

@webimpress, @froschdesign I just updated the PR, now it seems to work fine. I did a double tests for PHP 5.6 and PHP 7+. With 5.6 the PHP interpreter uses some bytes from test to test. With PHP 7+ the memory allocation is always zero. Please review now, thanks!