search

zendframework / zend-validator

Validator component from Zend Framework
BSD 3-Clause "New" or "Revised" License
181 stars 136 forks source link

Clean benign errors #132

Closed codisart closed 7 years ago

Xerkus commented 7 years ago

That method can be used/overriden by extending code so changing its signature will be a BC break.

It would be better to default $hostname to true and simplify following check to:

if ($local && $hostname && $length) {
    return true;
}
codisart commented 7 years ago

Thank you @Xerkus for your review. I did changes to my code.

weierophinney commented 7 years ago

Thanks, @codisart