search

zendframework / zend-validator

Validator component from Zend Framework
BSD 3-Clause "New" or "Revised" License
181 stars 136 forks source link

Zend\Math is required by Zend\Validator\Csrf but packae is not required #147

Closed heiglandreas closed 7 years ago

heiglandreas commented 7 years ago

Zend\Validator\Csrf requires the packages zend-session and zend-math but in composer.json they are only set as dev-requirements. Even though they are listed as suggestions, the package in itself is not usable without these packages. so they should be included in the require-section.

weierophinney commented 7 years ago

All validators are opt -in, and the majority have no dependencies outside those in the "require" section. For this reason, we list any validator-specific deps as suggestions, but do not require them.

Eventually, we may split these into separate packages so we can make those deps requirements, but for now, they are suggestions.

heiglandreas commented 7 years ago

Then the suggestions should at least include which validators can only be used when the suggested package is added…

weierophinney commented 7 years ago

Would you be willing to do a PR for that, or at least start one?

On Feb 18, 2017 8:21 AM, "Andreas Heigl" notifications@github.com wrote:

Then the suggestions should at least include which validators can only be used when the suggested package is added…

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-validator/issues/147#issuecomment-280848531, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlVzuWxutgn8bTXiligwIcUekj8PW5ks5rdv5agaJpZM4MFByw .

heiglandreas commented 7 years ago

Already at it 😉