[WIP] issue-125 - add unit test proving undefined index error

zendframework / zend-validator

Validator component from Zend Framework

BSD 3-Clause "New" or "Revised" License

181 stars 136 forks source link

[WIP] issue-125 - add unit test proving undefined index error #183

Closed codisart closed 7 years ago

codisart commented 7 years ago

bug created by #174 related to #125

weierophinney commented 7 years ago

Incorporated into #187.

codisart commented 7 years ago

@weierophinney I'm glad to have been able to help with these tests. (The least I could I do after adding a bug ^^) Next time, do not hesitate to ask me to do the code. This time, It was not clear for me what could be the correction since the behavior was not very straight forward.

weierophinney commented 7 years ago

@codisart Thanks a ton for getting the tests started! It took me a while to untangle what you were reporting, which I did by adding more test cases... at which point, it made sense to create the new pull request, as I then had an idea how to fix it. Will definitely provide reviews in the future to allow you to do the work yourself.