Closed DragonBe closed 4 years ago
Thanks, @DragonBe! With the imminent transition to the Laminas Project, I am expecting we will likely revisit the ability to bump a PHP version during a major series, and, as such, decided to do so here, as it will ensure we do not have any BC issues with your new class in the future. I added visibility to all constants, and added typehints to parameters and return values of all internal methods. Will release shortly with version 2.13.0.
This is the UndisclosedPassword validator discussed in #259 which uses PSR-18 http client interface for communicating with Have I Been Pwned? web service for validating passwords in a secure, safe way using K-Anonymity method.
IMPORTANT: The thing that might be a problem for this pull request is that PSR-18 composer package requires PHP 7.0 or higher.
All functionality is documented and provided with unit tests ensuring 100% code coverage.![image](https://user-images.githubusercontent.com/282825/56085067-9ce85a80-5e3d-11e9-99e3-bd2a8745369e.png)
Please review this pull request and let me know if I need to change or improve the functionality.