[BUG] - HTTPS Self Links Broken for Ports Other than 443

zendframework / zend-view

View component from Zend Framework

BSD 3-Clause "New" or "Revised" License

49 stars 61 forks source link

[BUG] - HTTPS Self Links Broken for Ports Other than 443 #194

Open jbh opened 5 years ago

jbh commented 5 years ago

When using HTTPS with a port other than 443, the self links returned remain HTTP.

Please see: https://github.com/zendframework/zend-view/blob/master/src/Helper/ServerUrl.php#L149

There are plenty of use cases where people will use ports other than 443 for their HTTPS needs. I believe this needs to be refactored to be less strict.

I'm happy to make the PR contribution, but I wanted to submit the issue first to make sure this doesn't break some standard.

weierophinney commented 5 years ago

:+1: for a PR for this!

jbh commented 5 years ago

Great. I'll work on doing that within the next two days. I have some other tasks in queue.

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-view; a new issue has been opened at https://github.com/laminas/laminas-view/issues/3.