zendframework / zend-view

View component from Zend Framework
BSD 3-Clause "New" or "Revised" License
49 stars 61 forks source link

Update head-script.md #196

Closed rcapile closed 5 years ago

rcapile commented 5 years ago
michalbundyra commented 5 years ago

Thanks, @rcapile!

rcapile commented 5 years ago

sorry I made things worse.

The documentation uses > to create a quote. It works fine in GitHub, but breaks completely at zf doc site.

https://docs.zendframework.com/zend-view/helpers/head-script/#headscript

I looking up if this a bug from mkdocs or there is something missing

michalbundyra commented 5 years ago

ping @froschdesign

what do you think about it?

rcapile commented 5 years ago

just FYI I tried changing < to &lt; it works with mkdocs (with default layout, not with zf layout) but it breaks at github.

it seems that fenced code blocks inside a quote does not work well with mkdocs

froschdesign commented 5 years ago

@rcapile

it seems that fenced code blocks inside a quote does not work well with mkdocs

This is not a problem of MkDocs: https://python-markdown.github.io/extensions/fenced_code_blocks/#syntax

rcapile commented 5 years ago

I just find out this is a known bug with no fix in sight

https://github.com/Python-Markdown/markdown/issues/53

froschdesign commented 5 years ago

@rcapile

I just find out this is a known bug with no fix in sight

Unfortunately, it's not supported and not a bug.

michalbundyra commented 5 years ago

@froschdesign do you think we can solve it somehow by separate script in our template? As we are doing couple other things - table_fix_pipes.php, table_responsive.php, etc...

froschdesign commented 5 years ago

@webimpress As workaround we can replace the backticks with the standard Markdown for code blocks (4 spaces). Then we can rewrite the HTML from:

<pre class="codehilite line-numbers"><code>…</code></pre>

to

<pre class="codehilite line-numbers language-php"><code>…</code></pre>

Then the code can be read but without colour.

michalbundyra commented 5 years ago

@rcapile all is working fine now :) We have made some changes in the template and fenced code blocks are working correctly. Thanks!