zendframework / zf-mkdoc-theme

MkDocs theme and gh-pages automation scripts for ZF documentation
MIT License
13 stars 13 forks source link

Updates needed for component selector #49

Open froschdesign opened 6 years ago

froschdesign commented 6 years ago

Examples:

froschdesign commented 6 years ago

Suggestion:

component-selector

ping @weierophinney, @thexpand

thexpand commented 6 years ago

@froschdesign @weierophinney Bigger font size for component name - OK Shadow for the whole drop-down - OK Shorter placeholder - Great

I just don't like the dark background of the headings. Seems too much. I suggest using a smaller font size, but capital letters with a light gray background. Here's a preview (combine this with the sticky headings from my PR):

screenshot from 2018-08-15 23-08-38

froschdesign commented 6 years ago

@thexpand

... with a light gray background

The problem: this results in a poor contrast ratio.

thexpand commented 6 years ago

@froschdesign That's why I added the capitalized letters :( I can't think of a better way to do this, unfortunately. By the way, higher contrast doesn't always mean better. Same goes to applying many colors, which I think is what we must escape from.

froschdesign commented 6 years ago

@thexpand

That's why I added the capitalized letters

It's fine for short text, but if the text is longer and smaller, it will be harder to read.

By the way, higher contrast doesn't always mean better.

In this case it helps a lot. (compare the screenshots)

Same goes to applying many colors, which I think is what we must escape from.

Then we have no problem here! 😉 Because the entire documentation uses a minimal color palette. Colored are only the code examples.