search

zendframework / zf2-documentation

Zend Framework 2 documentation sources
BSD 3-Clause "New" or "Revised" License
190 stars 570 forks source link

Add missing code so error is produced #1513

Closed edlongman closed 9 years ago

edlongman commented 9 years ago

If this function is omitted then a different error is seen. by adding this function it makes the runtime error show as expected by the tutorial

manuakasam commented 9 years ago

I'll check it this afternoon. Just looking over it briefly I'm not sure that's the case.

froschdesign commented 9 years ago

A complete paragraph is missing, which describes the error message for the missing controller action and the extension of the controller with the "list" action.

So the current fix is wrong.

manuakasam commented 9 years ago

Precisely. Honestly I wonder where in the world that paragraph got lost :D I'll get on it soon!

edlongman commented 9 years ago

I was just looking through is and thought, something is really wrong here as that is the wrong error

On Tue, Sep 8, 2015 at 3:33 PM, Manuel St. notifications@github.com wrote:

Precisely. Honestly I wonder where in the world that paragraph got lost :D I'll get on it soon!

— Reply to this email directly or view it on GitHub https://github.com/zendframework/zf2-documentation/pull/1513#issuecomment-138583850 .

froschdesign commented 9 years ago

@edlongman Can you create a new PR and close this one?

manuakasam commented 9 years ago

Ah damn, this is on me. Completely forgot about this one, will do it today, sorry :)

Frank Brückner notifications@github.com schrieb am Do., 24. Sep. 2015 um 09:38 Uhr:

@edlongman https://github.com/edlongman Can you create a new PR and close this one?

— Reply to this email directly or view it on GitHub https://github.com/zendframework/zf2-documentation/pull/1513#issuecomment-142840072 .

froschdesign commented 9 years ago

@manuakasam Nice! :+1:

manuakasam commented 9 years ago

OK, so I was just reading through the tutorial again getting my head around this.

The thing is: there's nothing wrong with it. We define a route that goes to ListController => indexAction()

We then create the controller without extending AbstractActionController which results in the error outlined in the documentation. After then extending the AbstractActionController we just get the error for the template. This is due to the fact that we rely on indexAction() rather than listAction() (or similar). The indexAction() is always provided per default from the AbstractActionController. Therefore the tutorial behaves correctly, I just tested this out.

@edlongman Can you describe what is happening on your end? My assumption is that you really just went with listAction() or something and therefore you see a different error. Am I correct with this assumption?

@froschdesign So in the end no error here after all. Though arguably relying on indexAction() may not have been the best course of action here. However the action-error-messages are covered at a later point within the tutorial when it comes to adding and editing the datasets.

froschdesign commented 9 years ago

@manuakasam

However the action-error-messages are covered at a later point within the tutorial when it comes to adding and editing the datasets.

Great! Thanks for your help.

edlongman commented 9 years ago

OK maybe I misunderstood this, unfortunately I don't think I can replicate what was happening but thank you for your help

On Fri, 25 Sep 2015 07:32 Frank Brückner notifications@github.com wrote:

@manuakasam https://github.com/manuakasam

However the action-error-messages are covered at a later point within the tutorial when it comes to adding and editing the datasets.

Great! Thanks for your help.

— Reply to this email directly or view it on GitHub https://github.com/zendframework/zf2-documentation/pull/1513#issuecomment-143141498 .

froschdesign commented 9 years ago

@edlongman Please close this issue.