zendtech / IbmiToolkit

PHP frontend to XMLSERVICE for IBM i development.
BSD 3-Clause "New" or "Revised" License
46 stars 34 forks source link

Validate $databaseNameOrResource parameter in Toolkit constructor #115

Closed alanseiden closed 4 years ago

alanseiden commented 4 years ago

Currently, if a script attempts to pass a failed database connection resource to the Toolkit constructor, this value of false gets interpreted as a blank system name, causing the toolkit to try a new database connection to this blank system name, rather than realizing a failed connection was passed in.

We should throw an Exception if a value of false is passed for $databaseNameOrResource.

alanseiden commented 4 years ago

ee92eb67dbbd891cd91d672758ad7f4dfea69242