zendtech / IbmiToolkit

PHP frontend to XMLSERVICE for IBM i development.
BSD 3-Clause "New" or "Revised" License
46 stars 34 forks source link

Detect transport type from database connection passed in #133

Open alanseiden opened 3 years ago

alanseiden commented 3 years ago

When instantiating the toolkit, users who pass in a database connection that is not ibm_db2 must either specify the transport type in parameter 4 or change toolkit.ini. It's extra work and makes it hard to remember what parameters need to be passed. The toolkit could, instead, automatically detect the transport type when a database connection is passed as parameter 1. Here is the constructor: https://github.com/zendtech/IbmiToolkit/blob/e9852fb2fd4b593c1d33d084b60a0b39831bda1b/ToolkitApi/ToolkitService.php#L25

NattyNarwhal commented 3 years ago

notes: