Removed PDO transaction for execXMLStoredProcedure()

zendtech / IbmiToolkit

PHP frontend to XMLSERVICE for IBM i development.

BSD 3-Clause "New" or "Revised" License

46 stars 34 forks source link

Removed PDO transaction for execXMLStoredProcedure() #141

Closed csears123 closed 3 years ago

csears123 commented 3 years ago

Removed transaction that was causing errors binding XML parameter to the PDO execute() function.

Issue:
https://github.com/zendtech/IbmiToolkit/issues/140

alanseiden commented 3 years ago

@chukShirley What do you think of the above--removing the beginTransaction() and commit() from PdoSupp? Why do you think those commitment control functions were used?

alanseiden commented 3 years ago

Although we toolkit maintainers can't duplicate Chris's error, we agree that beginTransaction() and commit() don't really belong here, or at least the aren't used in the other database transports, so we will remove for consistency. @chukShirley