zendtech / IbmiToolkit

PHP frontend to XMLSERVICE for IBM i development.
BSD 3-Clause "New" or "Revised" License
46 stars 34 forks source link

qshellCommand()=false when nonzero exit code #147

Closed alanseiden closed 3 years ago

alanseiden commented 3 years ago

When the Qshell exit code returns a nonzero value, the command has failed, even when Qshell provides no details on the error. The result of qshellCommand(), therefore, should be false.

NattyNarwhal commented 3 years ago

This makes sense; it might be a breaking change, but that code was relying on incorrect assumptions if so anyways.