zendtech / IbmiToolkit

PHP frontend to XMLSERVICE for IBM i development.
BSD 3-Clause "New" or "Revised" License
46 stars 34 forks source link

i5_connect(): default host to 'localhost' #153

Closed alanseiden closed 3 years ago

alanseiden commented 3 years ago

Adopt a more reliable way to set 'localhost' as the default host if empty $host was specified in i5_connect(). Although the $host parameter of i5_connect() defaulted to 'localhost' in the argument list, this was not a reliable way to ensure 'localhost' for an empty host value. We saw this at a client who used ('', '', '', array(i5_libl...)) and got an error about an unknown host value.

NattyNarwhal commented 3 years ago

argument lists strike again. sometimes I wonder if associative arrays or keyword arguments are the future. merging.