search

zendtech / IbmiToolkit

PHP frontend to XMLSERVICE for IBM i development.
BSD 3-Clause "New" or "Revised" License
46 stars 34 forks source link

Fix required parameters after optional parameters in method signatures #156

Closed jonkerw85 closed 3 years ago

jonkerw85 commented 3 years ago

Related to https://github.com/zendtech/IbmiToolkit/issues/154

NattyNarwhal commented 3 years ago

I thought I got most of these already, glad someone's catching the others.

FWIW, we internally do calls every Friday afternoons for PR review/Toolkit direction, so it should it should be reviewed/merged then - and if you didn't write this, we'd have looked at your original issue. It looks good at first glance anyways.

alanseiden commented 3 years ago

@wjonkerhulst Thank you. We will review your updates on Friday, if not before.