search

zendtech / IbmiToolkit

PHP frontend to XMLSERVICE for IBM i development.
BSD 3-Clause "New" or "Revised" License
46 stars 34 forks source link

crlf newlines should be converted to lf #169

Open NattyNarwhal opened 2 years ago

NattyNarwhal commented 2 years ago

It's a bad idea to leave it like this because it massively fowls whitespace in diffs/makes merges harder. PHP doesn't care about the newlines, and git can convert on the fly for Windows users, so storing crlf in the repo just makes things annoying.

NattyNarwhal commented 2 years ago

OFC, this will basically break all PRs in flight, so we should merge and close what we can.