search

zendtech / ZendOptimizerPlus

Other
914 stars 142 forks source link

Time for a new release? #208

Closed Jan-E closed 9 years ago

Jan-E commented 9 years ago

@dstogov (and others): Is not it time for a new release and bundle the new release in the tarballs of 5.4, 5.5 and 5.6? I was experiencing a lot of 'zend_mm_heap corrupted' errors while using Piwik with PHP 5.5.23 and OPcache 7.0.4. I then checked out the git-head (7.0.5-dev) and the errors did not reappear (yet?). My Centos6 websites are configured with Directadmin. At every PHP update opcache.so is rebuilt with the bundled release (i.e. 7.0.4), so I would welcome a new release.

laruence commented 9 years ago

Hmm, I can not recall what segfaults fixes are made after 7.0.4 is released... do you have any reproduce test scripts?

Jan-E commented 9 years ago

It is really hard to reproduce. Piwik is opening a lot of concurrent (Ajax) requests. Apache segfaults without a patch for https://bugs.php.net/bug.php?id=68486 and produces 'zend_mm_heap corrupted' errors when I applied one of the 2 patches for bug 68486.

Piwik is known for causing segfaults. They even have a FAQ for it: http://piwik.org/faq/troubleshooting/#faq_131

Anyway, with the latest OPcache the segfaults and/or mm heap corruption did not occur anymore.

Jan-E commented 9 years ago

We are running a week now with 7.0.5-dev and did not experience any segfaults or zend_mm_heap corruption anymore. I do not know what you have fixed since the 7.0.4 release, but 7.0.5-dev is definitely a lot more stable than 7.0.4. This really is worth a release IMHO.

nathanhruby commented 9 years ago

I'll throw in a "me too" if only because we have patches in dev that we are running with in our environment and it would be great to sync back up with upstream again.

remicollet commented 9 years ago

And perhaps a 7.0.5 in sync with 5.6.8 is needed for CVE-2015-1351 ? https://bugs.php.net/bug.php?id=68677

nathanhruby commented 9 years ago

doh, I missed the CVE attached to the bug. yeah, strongly agree.

laruence commented 9 years ago

Okey, thanks, I will make a 7.0.5 release this weekend :)

Jan-E commented 9 years ago

Friendly reminder to do this before 5.6.8 & 5.5.24 are being tagged.

laruence commented 9 years ago

released, but why this relates to 5.5/5.6's release? they have opcache in bundled..

remicollet commented 9 years ago

@laruence this is related to public announcement (with 5.5 / 5.6) of the CVE.

Jan-E commented 9 years ago

@laruence The bundled OPcache is AFAIK the latest release. That was 7.0.4 on Centos 6. See the remarks on opening this issue: https://github.com/zendtech/ZendOptimizerPlus/issues/208#issue-64728960

laruence commented 9 years ago

@remicollet I see, thanks :)