search

zeners / gnome-shell-teatime

MIT License
3 stars 3 forks source link

Fix vertical squashing of the panel icons #1

Closed jwrdegoede closed 4 years ago

jwrdegoede commented 5 years ago

The teapot and especially the progress circle icon in the panel are squashed with GNOME-3.32. The problem appears to be that the padding which we are requesting gets applied not only to the surface-size which we are being passed (which is 20 px wide for our 24 px size), but gets applied a second time using scaling squashing the image and making the progress circle non round.

This commit fixes this by removing the padding, as gnome shell automatically adds plenty of padding and directly requesting 20x20 as surface size, which results in a 20x27 surface as we are given the full height of the panel as height, but our own padding code takes care of that.

Signed-off-by: Hans de Goede hdegoede@redhat.com

zeners commented 4 years ago

sry, missed your pr, this isn't the main repo, would you mind make a pr against oleid/gnome-shell-teatime ?

jwrdegoede commented 4 years ago

Hi,

I just saw your comment from 24 days ago. I submitted the PR here, because it builds on top of your 3.32 compat changes.

I see you have already found my 3.36 compat work and merged it into your tree.

FWIW I have a PR open against the original Oleid repo here: https://github.com/oleid/gnome-shell-teatime/pull/52 but that unfortunately does not seem to not be activily maintained atm.

Regards,

Hans