search

zeners / gnome-shell-teatime

MIT License
3 stars 3 forks source link

Gnome shell 46 compatibility #7

Closed jwrdegoede closed 3 months ago

jwrdegoede commented 3 months ago

Add compatibility with gnome-shell 46, while keeping things compatible with gnome-shell 45.

This has been tested with gnome-shell 45.3 and 46-rc.

zeners commented 3 months ago

thanks for the commit, for me it looks like the popup-menu entry problem (#5) is still there

jwrdegoede commented 3 months ago

thanks for the commit, for me it looks like the popup-menu entry problem (#5) is still there

Note the "Fix the popup-menu entry to set a custom timer looking weird" commit is not about fixing #5, what it fixes is the text entry field at the bottom of the menu which you get when you right click on the teatime icon in the panel. That is the bottom entry of that menu where you can enter a custom time and then it will immediately start a timer for that long. Once you focussed that the text entry field used to turn white which looked weird and that is what is fixed by this commit.

About issue #5, I noticed the issue with editing existing / adding new timers in the preferences myself too. IIRC this started with GNOME40 when the extension preferences dialog moved to GTK4. I have tried to fix this several times, but I'm not really an expert on GTK, so I have not succeeded in fixing this.

I think we need to ask help from someone with more GTK4 experience to get this fixed.

zeners commented 3 months ago

@jwrdegoede thanks for explanation. I wasn't disturbed of the white background and the white placeholder text disappears when entering own values. It's ok for me, thank you.