search

zengenuity / civicrm_groupprice

CiviCRM extension that allows you to limit the display of individual prices in price sets to specific groups. This can be used to implement members-only pricing for events, as well as other use cases.
Other
3 stars 9 forks source link

Allow all group types and extend contact check to no logged in users #15

Closed graydigitalgroup closed 2 years ago

graydigitalgroup commented 2 years ago

The documentation stated that all groups can be used, but the code was only using SmartGroups. Changed the logic to allow all groups as long as the contact is in the group.

Added logic to try and determine if the contact to be checked is to be based on the logged in contact, a checksum contact, or an "On-Behalf Of" type scenario

zengenuity commented 2 years ago

@graydigitalgroup I came to review this PR and I see it's closed. Do the changes you made work for both types of groups?

rbaugh commented 2 years ago

Yes, I closed the PR as I had overlooked the static group portion. The issue ended up being more about the reliance on the Session of a logged in user.

I need to re-submit the PR with just the contact check I put in place.