search

zengkid / SmartTomcat

The Tomcat plugin for Intellij IDEA
Apache License 2.0
126 stars 55 forks source link

Added module to config. Updated project to latest versions #20

Closed jgmpzman closed 5 years ago

jgmpzman commented 5 years ago

This is a fix for: NullPointerException after updating IntelliJ #17

I ran into this issue myself and when I downloaded the code. It looks like if the configuration you enter for Deployment on the config is not the root directory of a module then looking up the module results in a null value. That causes a NullPointerException farther down the line. It seems like the user should be able to specify a Deployment Directory and the Module directory, so I added a config for the module. I also updated the gradle and intellij plugin imports to newer versions and verified on the latest intellij version 2019.1.1.

If you are interested in this PR, let me know and I will merge it in.

yuezk commented 5 years ago

Hi, @zengkid Are you plan to release a new version of this plugin, since it has been merged for a long time. A lot of users are waiting for this to fix the NPE exception. Thanks.

zengkid commented 5 years ago

Hi, Devin Yue

Already release the new version.

Regards Yi

发件人: Kevin Yue notifications@github.com 发送时间: Friday, September 20, 2019 9:49:46 PM 收件人: zengkid/SmartTomcat SmartTomcat@noreply.github.com 抄送: zengkid zengkid@msn.com; Mention mention@noreply.github.com 主题: Re: [zengkid/SmartTomcat] Added module to config. Updated project to latest versions (#20)

Hi, @zengkidhttps://github.com/zengkid Are you plan to release a new version of this plugin, since it has been merged for a long time. A lot of users are waiting for this to fix the NPE exception. Thanks.

― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/zengkid/SmartTomcat/pull/20?email_source=notifications&email_token=AAZZ3U52SBA33NZJCJJSZM3QKTIHVA5CNFSM4HMMEGPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7GYCWI#issuecomment-533561689, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAZZ3U52G5T4U3455DHDG53QKTIHVANCNFSM4HMMEGPA.

yuezk commented 5 years ago

@zengkid Have you uploaded it to the JetBrains plugin site? Seems that the last update time of this plugin is May 20, 2018. https://plugins.jetbrains.com/plugin/9492-smart-tomcat

zengkid commented 5 years ago

Hi, Kevin Yue

The plugin update is pending JetBrains approval, please wait for few days.

Regards

发件人: Kevin Yue notifications@github.com 发送时间: Sunday, September 22, 2019 9:32:30 PM 收件人: zengkid/SmartTomcat SmartTomcat@noreply.github.com 抄送: zengkid zengkid@msn.com; Mention mention@noreply.github.com 主题: Re: [zengkid/SmartTomcat] Added module to config. Updated project to latest versions (#20)

@zengkidhttps://github.com/zengkid Have you uploaded it to the JetBrains plugin site? Seems that the last update time of this plugin is May 20, 2018. https://plugins.jetbrains.com/plugin/9492-smart-tomcat

― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/zengkid/SmartTomcat/pull/20?email_source=notifications&email_token=AAZZ3U4UJHLUNL5VD5J2MIDQK5XW5A5CNFSM4HMMEGPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JGLDQ#issuecomment-533882254, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAZZ3U5N3BI2LQJKTJVZUF3QK5XW5ANCNFSM4HMMEGPA.