search

zengm-games / facesjs

A JavaScript library for generating vector-based cartoon faces
https://zengm.com/facesjs/
Apache License 2.0
1.25k stars 99 forks source link

Possibility of adding team name text to jerseys #26

Closed tomkennedy22 closed 2 years ago

tomkennedy22 commented 2 years ago

I've played around with the concept of adding in team names to jerseys, if a team has that feature enabled. It would require some changes for the display function to (A) determine if this team displays team name, and (B) actually pull the team name in. But the text can be added as a simple SVG element.

No worries if you're not interested, but I have some of the code to display working now, and could finish it up if the feature is appealing.

Screen Shot 2022-09-04 at 5 28 53 PM Screen Shot 2022-09-04 at 5 29 13 PM Screen Shot 2022-09-04 at 5 29 30 PM Screen Shot 2022-09-04 at 5 29 54 PM
dumbmatter commented 2 years ago

Thanks, it's a cool idea! But I think the text is too small with the space you have available now. And making the images taller to allow more space is probably not worth it. So I think I am going to pass on this one.